search

notaryproject / tuf

The Update Framework for OCI Registries
12 stars 11 forks source link

Registry upload #14

Closed mnm678 closed 2 years ago

mnm678 commented 2 years ago

requires #11 solves #12

This pr doesn't support references yet, as they are not yet merged into the oras-go library. Once that happens, I will update this.

mnm678 commented 2 years ago

@sudo-bmitch @trishankatdatadog I think this is ready for review.

sudo-bmitch commented 2 years ago

A visual scan LGTM. If we want to support some registries that filter other media types, we may want to consider the option to push with an image config media type and include a blank config. Cosign is doing this today to avoid filters from Hub and ECR. I wouldn't want that to be the default since it's against the OCI Artifact design, but a degraded behavior may be needed for some users.