search

notaz / pcsx_rearmed

ARM optimized PCSX fork
GNU General Public License v2.0
384 stars 207 forks source link

Some resource leak bugs #249

Closed ryancaicse closed 9 months ago

ryancaicse commented 2 years ago

Hi, there are some minor resource leak bugs in the program.

Files referenced by fin and fout are not closed before Line 59, 73, 84, 91, 98.

https://github.com/notaz/pcsx_rearmed/blob/fbf19ce6b6c02da47a67f58e23d8294cfcd18f55/tools/psxcimg.c#L56-L114

File referenced by fout is not closed before Line 137. https://github.com/notaz/pcsx_rearmed/blob/fbf19ce6b6c02da47a67f58e23d8294cfcd18f55/tools/psxcimg.c#L126-L139

notaz commented 2 years ago

The leaks don't matter since it's exiting the whole program with failure anyway. If someone wants to send a patch I don't mind though.

ryancaicse commented 2 years ago

Thanks, I would send patches soon

notaz commented 9 months ago

Closing as per previous explanation.