notaz / pcsx_rearmed

ARM optimized PCSX fork
GNU General Public License v2.0
384 stars 207 forks source link

Alien Resurrection (USA) in CHD format crashed then start "New game" on New Nintendo 2ds XL #257

Closed Maxcimkj closed 9 months ago

Maxcimkj commented 1 year ago

Hi! I use pcsx_rearmed emulator on New Nintendo 2ds XL with retroarch. Alien Resurrection (USA) in CHD format crashed then click start "New game" after loading. PBP image of Alien Resurrection (USA) work fine with good fps !!!

Game screenshot before crash: Alien Resurrection (USA)-220723-055759

Screenshot with error: error_screen

Error dump: crash_dump_00000002.zip Alien Resurrection CHD image: https://disk.yandex.com/d/YzXErNYZ9Qx6Nw

System info: New Nintendo 2ds xl - Firmware 11.15.0-47E Luma3DS v11.0

Retroarch info: retroarch_info pcsx_rearmed_core_info Core settings: PCSX-ReARMed.zip

notaz commented 1 year ago

It works on raspberry-pi4 but crashes hare in system libraries, so probably can't be fixed without the device.

mahirahman commented 1 year ago

Try Quick Menu -> Options, set CD Access Method to Sync and restart the core

notaz commented 9 months ago

Assuming this works now, feel free to reopen if not.

pcercuei commented 2 months ago

@notaz libpcsxcore/cdriso.c references this issue as a blocker for using the threaded cd-rom code. Is that safe to enable now?

notaz commented 2 months ago

No, there are even new functions now that ignore the async code altogether and would crash if it's enabled.

Is this threaded cdrom stuff actually that useful? If it's for .chd slowness there is now zstd support that should decompress faster.

pcercuei commented 2 months ago

@notaz I see you added physical CD-Rom support recently, it might be useful for that, no?

notaz commented 2 months ago

The physical cdrom stuff has it's own cache/read-ahead. It could probably be refactored to apply for cdriso too in favor of the other design simply because it's my own and easier for me to maintain (not that I have any proof that my design is actually better). But I'm not convinced this is needed for image file formats as the OS should be doing things like readahead anyway (except console OSes maybe?).

pcercuei commented 2 months ago

Ok. I have long-term plans to get it running on the Dreamcast (I added SH4 support in Lightning), so having physical CD-Rom support is great.

If this is not needed for image files, then maybe drop the threaded code - so that nobody else asks :)

notaz commented 2 months ago

Seems like it was added in libretro/pcsx_rearmed#391 by @justinweiss for the 3DS and reportedly also helped slow Android devices. But it's more than a year since this code has been disabled and nobody complained so IDK...

justinweiss commented 2 months ago

Yeah — the 3DS had extremely slow SD access, and games that streamed from disc were really badly affected by it. It was much less of a problem with CHD files.