search

notaz / pcsx_rearmed

ARM optimized PCSX fork
GNU General Public License v2.0
384 stars 207 forks source link

BIN/IMG support broke recently #261

Closed DrUm78 closed 1 year ago

DrUm78 commented 1 year ago

Software: PCSX fork: https://github.com/DrUm78/pcsx_rearmed Hardware: FunKey S handheld device with armv7 NEON

Not sure what commit broke it but ROMs with .cue/.bin or .cue/.img format does not load anymore, the user is just sent back to the desktop. Nothing relevant in the logs I got from GMenu2X. Maybe that's a side effect of the PBP fixes? It worked for sure before this one (does not mean it's the culprit though): d9e2b173fb11fea4976fb0a6c5feda6b654b4b46. .PBP and .CHD still work however. Does .BIN work for you?

Steps:

  1. Try to load any ROM with .cue/.bin or .cue/.img format
  2. Notice that you are sent back to the desktop
notaz commented 1 year ago

Pushed something, if it doesn't help you'll have to bisect the bad commit. It always worked for me as I test with .cue/.bin, so either FunKey does something different (maybe has alignment checks enabled) or your compiler does.

DrUm78 commented 1 year ago

Still the same issue with your last commit. Will bisect to find the culprit commit. 👍

DrUm78 commented 1 year ago

@notaz The culprit is the last libchdr update after https://github.com/rtissera/libchdr/commit/045f2a7f23f5ac10c0122f6f56e42023dfb71e2a. Restoring this commit fixes the issue. I close this ticket and will open one on the libchdr repo. Thanks for your help. 👍

DrUm78 commented 1 year ago

@notaz I just noticed that the last commit of libchdr has the same problem with .cso/.mp3 on PicoDrive (my repo: https://github.com/DrUm78/picodrive-funkey).

pcercuei commented 1 year ago

@notaz the fix will break things for big-endian systems...

DrUm78 commented 1 year ago

BTW I bisected libchdr commits and the one that breaks .bin/.img support (and .cso for PicoDrive too) is https://github.com/rtissera/libchdr/commit/40ec221c8a35a2fb90dc640a1e4e9fd6524506e8.