Remove Mega-CD support from Eke-Eke

notaz / picodrive

Fast MegaDrive/MegaCD/32X emulator

Other

290 stars 165 forks source link

Remove Mega-CD support from Eke-Eke #47

Closed Kekun closed 6 years ago

Kekun commented 7 years ago

Remove all code from Eke-Eke (hence, the Mega-CD support) to allow moving PicoDrive to a free license.

Admittedly this commit is somewhat dirty as it still exposes Mega-CD support to the user.

I propose the following:

keep this as a separate branch
change the license of the code from this branch to some free one
any commit sent to master must be dual licensed under MAME and the new license and should be pushed on the "free" branch
add Mega-CD support from MAME
merge on master
celebrate the new license :)

ghost commented 7 years ago

Uh, no?

Kekun commented 7 years ago

Why not? Check issue #41.

ghost commented 7 years ago

You are still left with notaz's decision.

Kekun commented 7 years ago

Well of course, I am forcing nothing but just proposing a change. :)

In the worst case I would really like to have the code on this branch to move to a free license, which implies the authors to be OK with that (Eke-Eke isn't hence the removal of his code), whether we merge it back once Mega-CD support is added back or not.

hooby3dfx commented 7 years ago

What testing have you done on this branch so far?

Kekun commented 7 years ago

@hooby3dfx I tested some Mega Drive and 32X games and they were working perfectly, I don't remember how though and it was quite some time ago. I didn't test loading disc games as I expected it to fail miserably as the controls has not been removed from the menus but the backend was removed.

notaz commented 6 years ago

Breaking the emulator is not acceptable to me, sorry. See issue #41 for a alternative proposal.