notaz / picodrive

Fast MegaDrive/MegaCD/32X emulator
Other
291 stars 165 forks source link

PDF_8BIT, wrong implementation? #95

Open fjtrujy opened 5 years ago

fjtrujy commented 5 years ago

Hello @notaz, I'm just raising this issue because I have ported PicoDrive for PS2 platform through RetroArch. The thing is that in order to increase the performance (as you know PS2 has a poor performance), I decided to use PDF_8BIT (to use palettes) in the PicoDrawSetOutFormat function. Is this functions working as expected with this specific parameter?

In the current status of the project, I think that none of the platforms officially support/use it. So after, so many tried, I gave up and I ended using PDF_NONE and implementing everything myself, the thing is, it wasn't easy to deal with MegaDrive, Sega Master System, MegaCD, 32X...... and for sure I will have hundreds of issues.

So I'm thinking that the current status PicoDrive is just ready to be used by PDF_RGB555 option. Do I'm right?

Thanks

notaz commented 5 years ago

I had a 8bit mode for GP2X I think, but it was more of a speed hack (and it was > 10 years ago already). So it's mostly a leftover from that time. It can be done this way but there will be problems with some games which change palette mid-frame. And yes you then need to handle everything yourself, separately for each system.

fjtrujy commented 5 years ago

Hello @notaz , thanks for your reply. As I was saying I'm porting it (actually I did it already) for PS2 through RetroArch, and this speed hack makes the difference to be able to play at stables 60fps or don't.

I didn't know about games that are changing Palette in the middle of the frame, quite interesting stuff.... if I'm right that issue will be impossible to solve, right?

Ok, just summing up, I think that after your message I can confirm that currently PicoDrive is just officially supporting PDF_RGB555, right?

Thanks

irixxxx commented 5 years ago

It might work in my fork. I actually did some work to get it running.

fjtrujy commented 5 years ago

I will give a try, thanks!