search

notblisy / RUBYSAPPHIREDLC

Custom E-Card Events based on Eon Ticket Dissasembly
158 stars 8 forks source link

JP version of celebi.me3 and celebiunlocked.me3 #1

Closed Wokann closed 1 year ago

Wokann commented 1 year ago

Hello, notblisy! I have some friends who are shiny hunters. When we heard this ecards dlc, we were very shocked, interseted and thanks for your works. Unfortunately, it seems these dlc only working on us version of ruby and sapphire. Some of my friends only have jp version of RS cartridge, and they also want to shiny hunt this Ageto Celebi. I often hear them asking if there is any way they can use this dlc on jp to catch shiny Celebi. So after some research based on your video and source codes and compare the difference between us and jp RS rom, I completed the jp version of Celebi scripts. There may be many other people who have the same questions and demands, so I hope to pull requset my files so that this part of the players can be helped.

  1. Adjust ram&rom adresses in the script to let it works on JP version of ruby and sapphire.
  2. Adjust the text layout so that the English text displayed in JP rom won't exceed the range.

POKEMON_RUBY_AXVJ_00-0 POKEMON_RUBY_AXVJ_00-1 POKEMON_RUBY_AXVJ_00-2 POKEMON_RUBY_AXVJ_00-3 POKEMON_RUBY_AXVJ_00-4 POKEMON_RUBY_AXVJ_00-5

notblisy commented 1 year ago

Hi, thanks for the ME3 files.

I've been working on localizations for all languages other than English and E-Cards for them as well.

I'll check legality Monday when I get home to make sure it's fine and merge it until I finish the full version.

(Although I doubt there is a legality issue if you got it to spawn without it being a bad egg lol)

Wokann commented 1 year ago

E-cards files have more information than me3 files, up to now I only found disammbly of US e-card but not jp e-card disam. That's why I just make .me3 file because it just contain the mainly ingame event scripts and asm code while codes about e-reader en or jp doesn't contian.

I've checked the legality of this celebi caught in jp, the PkHex checked that it's legal. And here is my note when editing scripts and the difference between us and jp addresses. Hope this can help you check my file and localization for other languages.

celebi script for jp.txt

My modification of functions and texts has ensured that the length and relative address relationship between functions has not been changed which makes it easier for you to use hex editors to compare jp.me3 with your origin file.