Corrected precedence of onCall, withArgs & returns/throws

note35 / sinon

Standalone and test framework agnostic Python test spies, stubs and mocks (pronounced "sigh-non").

BSD 2-Clause "Simplified" License

13 stars 4 forks source link

Closed jonathan-benn closed 6 years ago

jonathan-benn commented 6 years ago

Fixes note35/sinon#23 Fixes note35/sinon#29 Fixes note35/sinon#31

note35 commented 6 years ago

Sry for my slow speed review in advance, I will be on my vacation until next Wed. (No computer near me...only use smartphone to review the code)

The test result of this change LGTM. (But we might be able to get rid of some repeated test in the future)

I have not read the detail of __gen_retfunc_with_args, __gen_retfunc_without_args, __gen_stub_func. I will do that and the other 2PR ASAP.

jonathan-benn commented 6 years ago

Hi Kir,

I've made all the requested changes, except I am waiting for more information from you regarding the function signature change.

Enjoy your vacation! :)

--Jonathan

jonathan-benn commented 6 years ago

Hi Kir,

I made all the changes except for the one to _append_condition. Thanks for the feedback! This project is a fun challenge.

--Jonathan