notebookPowerTools / vscode-kusto

Kusto Notebooks
MIT License
28 stars 8 forks source link

Hundreds of invalid problems show up for a TS file when Kusto notebook extension is installed #45

Closed DonJayamanne closed 3 years ago

DonJayamanne commented 3 years ago

Does this issue occur when all extensions are disabled?: No

Steps to Reproduce:

  1. Update to latest Insiders (by default comes with TypeScript dev version 20210806)
  2. Open https://github.com/microsoft/vscode-jupyter
  3. ๐Ÿ› 999 problems immediately reported, most of which appear to be invalid, e.g. complaining about reserved keywords like constructor and import not being defined
  4. Problems continue to be reported after downgrading to TS 4.3.5 and reloading recording (16)
  5. If I disable https://marketplace.visualstudio.com/items?itemName=donjayamanne.kusto that stops the problems from being reported. However that extension has not been updated in over a month, and this only started happening this morning after I updated Insiders, so I'm filing this issue here as it seems like document selector filters for the language service might not be being correctly applied
sbatten commented 3 years ago

Started seeing this today as well

jakebailey commented 3 years ago

We just hit this while doing our normal test run for Pylance in VS Code insiders; those that had the Kusto extension installed started getting these messages in Python files.

DonJayamanne commented 3 years ago

Just pushed a new version of the extension, with a minor tweek. Not sure that fixes it. If it happens again, please could you send me some logs from the console window. I'm not seeing this at my end.

jakebailey commented 3 years ago

@heejaechang said that it looks like it's been fixed (though I don't see the code pushed here to take a peek).

heejaechang commented 3 years ago

It didn't repro after my vscode insider is updated. it might be the vscode insider that had issue.

luabud commented 2 years ago

@DonJayamanne I have just reproduced this issue with a Python file again on github.dev ๐Ÿ˜ข

Kusto notebooks version 0.3.8 VS Code version 1.62.0-insider