notebookPowerTools / vscode-kusto

Kusto Notebooks
MIT License
28 stars 8 forks source link

Question: How to best handle magics in vscode notebooks #50

Open cccs-jc opened 2 years ago

cccs-jc commented 2 years ago

@DonJayamanne I found this vscode-kusto extension and I believe it might contain all the answers to my questions.

I'm new to vscode development. I'm a bit more familiar with JupyterLab and jupyterlab-lsp which leverages the vscode LSP protocol and language servers. I've raised this issue with vscode-jupyter

https://github.com/microsoft/vscode-jupyter/issues/8198

As you see from my issue the way jupyterlab-lsp handles magics is by way of transclusions. However I believe you do something similar here https://github.com/notebookPowerTools/vscode-kusto/blob/ba2cf299ecb0a2ab91a9ec94103445d895c05263/src/extension/languageServer/browser/index.ts#L79

Does this occur on the client side (in vscode) so that the language server sees the correct text?

To detect %%sql cells and fix the text what do I need as a minimum in my own vscode extension.