search

notepad-plus-plus / notepad-plus-plus

Notepad++ official repository
https://notepad-plus-plus.org/
Other
22.97k stars 4.6k forks source link

Solarized dark theme issues with Markdown files #6140

Open ghost opened 5 years ago

ghost commented 5 years ago

Description of the Issue

When using the 'Solarized Dark Theme' with no changes Markdown files are rendered very poorly and are difficult to read. Also for some reason the Markdown language shows (default) which I don't remember ever setting. In fact, Markdown does not even show up in the languages dropdown.

Steps to Reproduce the Issue

  1. Select 'Solarized Dark' as a theme
  2. Open a Markdown (*.md) file

Expected Behavior

Proper coloring consistent with the theme similar to others.

Actual Behavior

See screenshot below which loads the README.md file from this repository in a new file.

Screenshot of the issue: https://i.imgur.com/kviRfeR.png

Debug Information

Notepad++ v7.7.1 (64-bit) Build time : Jun 16 2019 - 21:24:47 Path : C:\Program Files\Notepad++\notepad++.exe Admin mode : OFF Local Conf mode : OFF OS : Windows 10 (64-bit) Plugins : none

sasumner commented 5 years ago

TBH I don't know that anyone will ever address this. If you care enough, your best shot may be fixing it yourself and submitting a PR.

rddim commented 5 years ago

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5600

https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5600#issuecomment-487482034

longtth commented 5 years ago

How did you enable syntaxhighlighting for markdown files (.markdown, .md)? I'm using v771 but it doesn't has markdown in Language menu.

ismael-miguel commented 5 years ago

How did you enable syntaxhighlighting for markdown files (.markdown, .md)? I'm using v771 but it doesn't has markdown in Language menu.

It's an "User Defined language file" (hint: bottom-left corner).

Possibly, the used file is in https://github.com/Edditoria/markdown-plus-plus. Solarized was added on 19th January 2019.

ismael-miguel commented 5 years ago

When using the 'Solarized Dark Theme' with no changes Markdown files are rendered very poorly and are difficult to read. Also for some reason the Markdown language shows (default) which I don't remember ever setting. In fact, Markdown does not even show up in the languages dropdown.

You have an "User Defined language file" (hint: bottom-left corner). It's possible that it was added as an experiment or for necessity, a while ago, and you forgot.

You have the file from https://github.com/Edditoria/markdown-plus-plus You can compare the syntax highlighted with the default theme: https://github.com/Edditoria/markdown-plus-plus/blob/master/theme-default/markdown-plus-plus-default-screenshot.png

All you need to do is to get the Solarized theme, and use it.

ghost commented 5 years ago

@ismael-miguel I did not define this language. And in fact on a second machine I did a clean install and had the same issue. It also showed 'User defined language' and this is without ever opening the settings. I never added themes from another location, only ever using the official NPP installer.

ismael-miguel commented 5 years ago

User defined languages aren't defined in the settings.

They can be added/imported from "Language" > "Define your language..." option.

ghost commented 5 years ago

What I am saying is that I never added or configured the language and even on a new install this is how Markdown files render, including showing the user defined label.

sasumner commented 5 years ago

What @evitalis says is correct: Without changing anything in a default N++ install, markdown files (.md) are detected and shown as UDL.

ismael-miguel commented 5 years ago

Now THAT is weird as hell.

Maybe the markdown was somehow included in there by default? Is it showing in the User Defined Language editor?

sasumner commented 5 years ago

Maybe the markdown was somehow included in there by default?

That's what we've been trying to tell you

Is it showing in the User Defined Language editor?

Well, is it for YOU?

chcg commented 5 years ago

In scintilla MD lexer was added with 2.02:

Markdown lexer added. Feature #2844081.

maybe N++ support via scintilla lexer would result in a better user experience than the UDL solution available right now. @donho What do you think about adding MD lexer support?

ismael-miguel commented 5 years ago

Well, is it for YOU?

I can't test it. I have an old version at home and have the Markdown user defined language installed.

lucastucious commented 5 years ago

Same issue

dodmi commented 5 years ago

You may replace the language file by this one. It's the same as the one coming with Notepad++, but instead of the "white" background, it uses transparent background. But the markdown file will probably be hard to read on a dark background with this language file... userDefinedLang-markdown.default.modern.zip

ghost commented 4 years ago

Any update coming for this by chance? I am still seeing the issue with 7.8.7.