search

notepad-plus-plus / nppShell

Provide Explorer context menu entry "Edit with Notepad++"
GNU General Public License v3.0
25 stars 13 forks source link

Added resource file for version info #22

Closed GurliGebis closed 1 year ago

GurliGebis commented 1 year ago

This adds a resource file for versioning the dll, with the metadata for version 8.5.2 This should fix #16

GurliGebis commented 1 year ago

@donho is this what you mean by versioning? 🙂

GurliGebis commented 1 year ago

@donho Sure, I'll try 🙂- right now it seems like git is insisting it is a binary file. I'll see what I can do.

GurliGebis commented 1 year ago

@donho fixed - it was Visual Studio insisting on using UTF-16 with a BOM, causing git to insist it is a binary file. Changed it to UTF-8, and now it works 🙂

GurliGebis commented 1 year ago

@donho I have updated the metadata as we talked about above 🙂

GurliGebis commented 1 year ago

@donho also, can you include this in the 8.5.2 release? (Since we really should be having versioning info in the dll)

donho commented 1 year ago

@donho also, can you include this in the 8.5.2 release? (Since we really should be having versioning info in the dll)

@GurliGebis Notepad++ v8.5.2 has been released 3 hours ago: https://notepad-plus-plus.org/news/v852-released/

It (the commit of this PR) will go into v8.5.3 for sure :)

GurliGebis commented 1 year ago

@donho great, thanks. And contratz on 8.5.2 - it's been an interresting release 😀🚀