Fix opening multi-files on Notepad++ multi-instance mode regression

notepad-plus-plus / nppShell

Provide Explorer context menu entry "Edit with Notepad++"

GNU General Public License v3.0

25 stars 13 forks source link

Fix opening multi-files on Notepad++ multi-instance mode regression #37

Closed donho closed 1 year ago

donho commented 1 year ago

Before this commit, if N files are selected, NppShell calls Notepad++ N times (each time for per file). In this commit, we call Notepad++ only once, instead of calling it N times.

Fix #36, fix https://github.com/notepad-plus-plus/notepad-plus-plus/issues/13778

donho commented 1 year ago

@GurliGebis Since I've got vacant time, I do the fix for this issue. Could you review this PR please?

donho commented 1 year ago

Hmm... it doesn't really fix it. I'll do another commit to get it right.

donho commented 1 year ago

@GurliGebis Ready for being reviewed, It should be OK now.

GurliGebis commented 1 year ago

@donho looks exactly like the correct solution 🙂