search

notepad-plus-plus / userDefinedLanguages

Notepad++ User Defined Languages Collection
593 stars 380 forks source link

graphviz #24

Closed flytape8490 closed 4 years ago

flytape8490 commented 4 years ago

The graphviz UDL does not point to an xml, instead it points to an html document

fatgonzo commented 4 years ago

Ran into this as well while trying to grab the UDL for Tinyfugue. It appears to apply to the following files:

UDLs/TinyFugue_byYrwin.xml UDLs/StringTemplate3_byAnnaCzerwiec.xml UDLs/MSC-Patran_by-onurarifyasa.xml UDLs/MSC-Nastran_by-onurarifyasa.xml UDLs/HQL_byAkeelUdar.xml UDLs/GraphViz_by-signmotion.xml UDLs/AuditCommandLanguage-ACL_byJChen.xml UDLs/AsteriskExtensionLanguage-AEL_by-eyzel.xml

The content seems to be the download page served by Sourceforge and it seems these 7 UDL files resided under different projects at Sourceforge and were linked to as such instead of their respective Notepad++ project URL in the archived UDL list page that the current one was made from and therefore not copied over with the rest.

@pryrt I saw that you had moved the UDL list files from SF and worked on scripting their conversion but I have no idea how Github works so I couldn't tell if you are still working on the TODOs or if you forgot, since the issue (#7) was closed. Leaving this here in case you did forget, pardon my ignorance of Github if you didn't.

Just to be clear, this is how they were linked, quoting from the HTML of the old UDL list:

Tinyfugue (and the other anomalous ones respectively):

<a rel="nofollow" class="external text" href="https://web.archive.org/web/20180814202307/http://sourceforge.net/projects/tfimperial/files/userDefineLang_TF.xml/download">Tiny Fugue</a>

The rest

<a rel="nofollow" class="external text" href="https://web.archive.org/web/20180814202307/http://notepad-plus.sourceforge.net/commun/userDefinedLang/UDL_TodoTxt.xml">Todo.txt</a>

chcg commented 4 years ago

The download link for github content as e.g for UDL should not be the path to the html site at https://github.com/signmotion/graphviz-syntax-highlighting/blob/master/graphviz-notepad-udl.xml , but https://raw.githubusercontent.com/signmotion/graphviz-syntax-highlighting/master/graphviz-notepad-udl.xml

Probably the validator script could be extended to check not only that the download is possible, but also that the content is indeed a xml file. Maybe even a xml schema check that it is a udl 2.1 (there are still older versions of UDL than 2.1 -> unclear if N++ can still handle all of them and udl is backwards compatible)

chcg commented 4 years ago

Fixes, see PR #25

Additional findings to the one above: Html 404 Download failure: UDLs\EGL-EnterpriseGenerationLanguage_byKoen.xml

Zip files: UDLs\Alloy_by-lausdahl.xml

Zips with UDL + autocompletion part: UDLs\jQuery_byJamesAllardice.xml UDLs/MSC-Patran_by-onurarifyasa.xml UDLs/MSC-Nastran_by-onurarifyasa.xml

pryrt commented 4 years ago

25 closed the issue