search

notepad-plus-plus / wingup

WinGup - Generic Updater for Windows
http://wingup.org/
GNU Lesser General Public License v3.0
47 stars 31 forks source link

Provide more info if no update is available #15

Closed mere-human closed 3 years ago

mere-human commented 3 years ago

Add a note that auto-updater might be not activated yet. Add a link to a download site so that a user can go and check for updates manually.

Fix notepad-plus-plus#13

donho commented 3 years ago

@mere-human No force push please, just add new commit.

mere-human commented 3 years ago

Now it looks a bit better as for me: image

mere-human commented 3 years ago

Now the XML has a single string with "\r". With unescaping the text from XML it works fine. image

donho commented 3 years ago

@mere-human Could you test your code ? I don't ask you test it crazily like @sasumner does, but just test once on the basic feature that you implemented before requesting review. Thank you. :)

sasumner commented 3 years ago

ask you to test it crazily like @sasumner does

Does this mean I test my own implemented features crazily? :-) Or does it mean I ask other people to test crazily? :-)

donho commented 3 years ago

@sasumner

Does this mean I test my own implemented features crazily? :-)

It does. And it's a compliment believe me :)

mere-human commented 3 years ago

Could you test your code ?

I usually test my code. But I can get distracted when the review process is long. Sorry about that. I will try to test my changes more thoroughly.