notepadqq / notepadqq-packaging

Packaging scripts and files for Notepadqq
MIT License
21 stars 12 forks source link

Fixes for PKGBUILD + Adding GTK Package #36

Closed flamusdiu closed 9 years ago

danieleds commented 9 years ago

One minor thing I noticed: in notepadqq-git/PKGBUILD, shouldn't pkgver refer to commit notepadqq/notepadqq@7a175b203c3cecb93cb4143f894987848e4752aa ?

flamusdiu commented 9 years ago

I always have the git version point to the top of the master branch. I can change the version string to have something like "v44.0." if you would like that better? I don't think forcing the git version to be stuck at a tag or commit would be good sense most people would assume (I know bad word) that it's the latest and greatest thing. =)

danieleds commented 9 years ago

Yeah, my bad! I looked too quickly and I didn't realize that it was the git version. Merging! ;-)

flamusdiu commented 9 years ago

@danieleds LOL. It's alright. I've done worst. =D