search

notfood / RimWorld-Miniaturisation

If it has a name, you can shrink it.
6 stars 12 forks source link

AdditionalLighting hash collision #5

Closed TheRealElysium closed 8 years ago

TheRealElysium commented 8 years ago

Hash collision between Lighting_CeilingLamp_Blueprint_Install and Kibble: both have short hash 48559

Error on map load from Lighting_CeilingLamp. I was using these lamps previously and did not get this error until AdditionalLighting support was added to my game.

eskoONE commented 8 years ago

That's weird. Try deleting the XML of it and try again. It is working for me without problems.

eskoONE commented 8 years ago

Just realized that's the fault of the DLL not the XML. Had a similar issue with the crematorium.

biship commented 8 years ago

I get this every time I load my game: Hash collision between Lighting_CeilingLamp_Blueprint_Install and Kibble: both have short hash 48559

notfood commented 8 years ago

Do you have EPOE? Their update recently caused hash issues.

TheRealElysium commented 8 years ago

Yeah I do, I'll try loading without it.

Update: Loaded a new map without EPOE and still got the same error, so I don't know what might be causing it.

It doesn't seem to have affected my game in any way yet, but I'll let you know if that changes.

biship commented 8 years ago

Same results for me. I can't find either Lighting_CeilingLamp_Blueprint_Install or Kibble in my save game, so I assume it's just the games assignment of hash to a name. I can make and use KIbble without issue.

notfood commented 8 years ago

It appears that these overrides are not old save safe. I've gotten similar reports when people update old saves. I'll investigate further.

notfood commented 8 years ago

Can you guys test this branch? The DLL is in there. The difference is that this one queues a miniaturisation def cross load request instead of mangling its own before they exist, should be safer.

postload-injection

Load order matters now, load after everything you wish to miniaturise. It's also not old save compatible. The hashes and names of the minified things change, make sure to erase any minified thing around or not play with an old save at all.

TheRealElysium commented 8 years ago

This appears to have fixed the issue, nice work.