notfood / RimWorld-Outfitted

Outfit management
2 stars 9 forks source link

Incompatibility with Hospitality mod #12

Open Skullywag opened 3 years ago

Skullywag commented 3 years ago

Using this mod with Hospitality will result in guests not buying stuff, enabling the job logging on a guest results in this error when they attempt start the buying job:

Exception in Verse.AI.ThinkNode_PrioritySorter TryIssueJobPackage: System.NullReferenceException: Object reference not set to an instance of an object at Outfitted.OutfittedMod.ApparelScoreRaw (Verse.Pawn pawn, RimWorld.Apparel apparel, RimWorld.NeededWarmth neededWarmth) [0x00000] in <44eab0fe202d47418afef805f9237400>:0 at Outfitted.JobGiver_OptimizeApparel_ApparelScoreRaw_Patch.Prefix (Verse.Pawn pawn, RimWorld.Apparel ap, System.Single& result, RimWorld.NeededWarmth _neededWarmth) [0x0000c] in <44eab0fe202d47418afef805f9237400>:0 at (wrapper dynamic-method) RimWorld.JobGiver_OptimizeApparel.RimWorld.JobGiver_OptimizeApparel.ApparelScoreRaw_Patch1(Verse.Pawn,RimWorld.Apparel) at Hospitality.JoyGiver_BuyStuff.ApparelScoreGain (Verse.Pawn pawn, RimWorld.Apparel ap) [0x0007b] in :0 at Hospitality.JoyGiver_BuyStuff.Likey (Verse.Pawn pawn, Verse.Thing thing) [0x0003e] in :0 at Hospitality.JoyGiver_BuyStuff+<>cDisplayClass5_0.b5 (Verse.Thing t) [0x00000] in :0 at Verse.GenCollection.MaxBy[TSource,TKey] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] selector, System.Collections.Generic.IComparer1[T] comparer) [0x0004b] in <d72310b4d8f64d25aee502792b58549f>:0 at Verse.GenCollection.MaxBy[TSource,TKey] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] selector) [0x00007] in <d72310b4d8f64d25aee502792b58549f>:0 at Hospitality.JoyGiver_BuyStuff.TryGiveJob (Verse.Pawn pawn) [0x000c3] in <f7f6b1b841ba4733b81d7ee58f78f413>:0 at Hospitality.JobGiver_Relax.GetJob (Verse.Pawn pawn, System.Collections.Generic.List1[T] allDefsListForReading, Verse.AI.Job& job) [0x00027] in :0 at Hospitality.JobGiver_Relax.TryGiveJob (Verse.Pawn pawn) [0x000d9] in :0 at Verse.AI.ThinkNode_JobGiver.TryIssueJobPackage (Verse.Pawn pawn, Verse.AI.JobIssueParams jobParams) [0x00000] in :0 at Verse.AI.ThinkNode_PrioritySorter.TryIssueJobPackage (Verse.Pawn pawn, Verse.AI.JobIssueParams jobParams) [0x000fc] in :0 Verse.Log:Verse.Log.Error_Patch2(String, Boolean) Verse.AI.ThinkNode_PrioritySorter:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) Hospitality.ThinkNode_FilterGuestRooms:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) RimWorld.ThinkNode_Duty:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Conditional:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Tagger:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Subtree:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) RimWorld.ThinkNode_JoinVoluntarilyJoinableLord:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.ThinkNode_Priority:TryIssueJobPackage(Pawn, JobIssueParams) Verse.AI.Pawn_JobTracker:Verse.AI.Pawn_JobTracker.DetermineNextJob_Patch5(Pawn_JobTracker, ThinkTreeDef&) Verse.AI.Pawn_JobTracker:TryFindAndStartJob() Verse.AI.Pawn_JobTracker:Verse.AI.Pawn_JobTracker.EndCurrentJob_Patch1(Pawn_JobTracker, JobCondition, Boolean, Boolean) Verse.AI.Pawn_JobTracker:JobTrackerTick() Verse.Pawn:Tick() Verse.TickList:Tick() Verse.TickManager:DoSingleTick() Verse.TickManager:TickManagerUpdate() Verse.Game:UpdatePlay() Verse.Root_Play:Update()

Is this something that can be fixed in this mod, I know this really only messes with scores but looking at the below it just calls ApparelScoreRaw, why would this fail?

https://github.com/OrionFive/Hospitality/blob/develop/Source/Source/JoyGiver_BuyStuff.cs

BryanAldrich commented 3 years ago

I think this may be the same as the AnimalGear #9 issue. I posted the build of my fork https://github.com/BryanAldrich/RimWorld-Outfitted/releases/tag/1.2-hotfix