search

notgoodusename / OsirisAndExtra

Other
128 stars 63 forks source link

Save location of watermark & spectator list in config and load on loading new config #205

Closed 2lag closed 2 years ago

2lag commented 2 years ago

Pretty self explanatory I feel, would be pretty easy feature to implement I believe.

2lag commented 2 years ago

Also, skin changer in its entirety is broken afaik

notgoodusename commented 2 years ago

Spectator list is already saved, not watermark tho also the skinchanger works totally fine, you sure you enabled it?

Navoichyk commented 2 years ago

Spectator list is already saved, not watermark tho also the skinchanger works totally fine, you sure you enabled it?

How could i make the watermark, keybinds list, purchase list, etc save on config?

Navoichyk commented 2 years ago

image this stuff?

notgoodusename commented 2 years ago

How could i make the watermark, keybinds list, purchase list, etc save on config?

How spectatorList is declared (Look at pos) How spectatorList is saved And how spectatorList is loaded

That should give you and idea on how to save it

notgoodusename commented 2 years ago

image this stuff?

That stuff is for when you load a cfg and have a position saved

Navoichyk commented 2 years ago

How could i make the watermark, keybinds list, purchase list, etc save on config?

How spectatorList is declared (Look at pos) How spectatorList is saved And how spectatorList is loaded

That should give you and idea on how to save it

image if that is how you save it, shouldnt keybind list's location be saved too because its the same?

Navoichyk commented 2 years ago

It looks like keybindlist, and spectator list is saved, and loaded the exact same way so i dont understand why keybind list isnt saving location

Navoichyk commented 2 years ago

image like this? (also in config)

2lag commented 2 years ago

fixed :D tysm for the pointers it was way easier than i thought it'd be

Navoichyk commented 2 years ago

fixed :D tysm for the pointers it was way easier than i thought it'd be

Can you show me how you did it?

NeurAIGod commented 2 years ago

Why was this issue closed? The project still contains this error. Just because you solved it personally on your local instance doesn't mean that this issue has been fixed. @notgoodusename can you please reopen it until it actually has been resolved?

2lag commented 2 years ago

fixed :D tysm for the pointers it was way easier than i thought it'd be

Can you show me how you did it?

I did it with exactly what you showed me in the code! I just adapted each of the settings to have the setting within the config files to save the location of any window that would be open. You can make it just one command and call it in every function where it is needed, or you can copy the exact code and change the reference names in every function where it is needed.

NeurAIGod, I closed this thread because I thought it is a pretty self explanatory fix after you're able to find the location of what you're trying to work on. Sorry for any confusion, but I believe the issue has been resolved as of the most recent commits today, thanks to your pull request!

NeurAIGod commented 2 years ago

NeurAIGod, I closed this thread because I thought it is a pretty self explanatory fix after you're able to find the location of what you're trying to work on.

Since I think that you are new to Workflows allow me to elaborate: One can open issues for issues and questions, however they should only be closed whenever the question was answered or a fix was implemented. Closing an issue is the same as saying that it has been resolved and requires no further action thus a request could be forgotten. No matter how simple the fix is, if it's a legitimate issue it should stay open unless resolved.

Sidenote: if one asks a question it should be obvious that it is a question and not an issue to avoid confusion.