notgoodusename / OsirisAndExtra

Other
127 stars 64 forks source link

hitchance problem, optimization, bad code #560

Closed exfuturesolutions closed 1 year ago

exfuturesolutions commented 1 year ago

https://github.com/notgoodusename/OsirisAndExtra/blob/main/Osiris/Hacks/AimbotFunctions.cpp#LL559C8-L559C8 we haven't check many hitboxes it lowers our optimization and so unuseful, cuz we check if we have chance to hit certain hitbox for certain damage

notgoodusename commented 1 year ago

Explain yourself better also if you mean that the for loop is unnecessary, it isn't, the reason i check for every hitbox is because the function needs to check a certain hitbox this is because the function creates a "oval" (based on the position, size and rotation of the hitbox) and compares if the given direction hits said "oval"

exfuturesolutions commented 1 year ago

why do u check each hitbox for intersect if u want to hit certain hit box, chosen by ur hitscan?

exfuturesolutions commented 1 year ago

why not just bool bIntersectedCertainHbox = hitbox_intersection(certain_hbox, matrix) if(!bIntersectedCertainHbox) continue else hits++ if u goin check another hitbox for intersect it wont hit needed damage simple example (why u checkin' legs for intersect if u want hit head) xdd so u dont need to check another hitboxes for intersect u need certain bro, arent i right?

BlackBookOfficial commented 1 year ago

From what i can see is that hitchance is near 1:1 mutiny. So i guess what ever mutiny has try to figure that out and make it faster.

exfuturesolutions commented 1 year ago

idk where this hitchance from but it's not proper to check up to (256 * hitboxes) intersections, it will slow the performance, also results will be damn not accurately cuz u check intersection for the whole enemy when need check only one intersected hitbox

notgoodusename commented 1 year ago

idk where this hitchance from but it's not proper to check up to (256 * hitboxes) intersections, it will slow the performance, also results will be damn not accurately cuz u check intersection for the whole enemy when need check only one intersected hitbox

change the code and then see why it doesn't work, im not going to explain something that requires 1 google search