noth-k / pe

0 stars 0 forks source link

[Functionality Flaw] addressbook.json file can be manipulated directly to add people of same email address #2

Open noth-k opened 3 days ago

noth-k commented 3 days ago

In the UG it was stated that "Each person is distinguished using their email address". However, when the addressbook.json file (within the same directory of the java file) is directly edited, 2 people with the same email address can exist at the same time

Implication: This could cause confusion when carrying out tests in the future and hence, I have marked it as a functionality bug with medium severity

To reproduce:

  1. Access the addressbook.json file in the data file, which is in the same directory, of the application
  2. Edit 2 people's email address to match
  3. Run application,

There was not any error message

nus-pe-bot commented 12 hours ago

Team's Response

We have followed the given steps to try to reproduce the error on both Windows and Mac. However, we were unable to reproduce the error both times. An error message: "Unable to load contacts due to unexpected data loading error." is shown. As you have not provided us with a screenshot of what you encountered, we are unable to further investigate the issue as we are unable to view whether your app ran properly without any error message after editing the JSON and your participant list got updated to display 2 participants with the same email.

On Mac:

Screenshot 2024-11-17 at 5.39.14 PM.png

On Windows:

photo_2024-11-17_17-40-22.jpg

photo_2024-11-17_17-40-24.jpg

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: [replace this with your explanation]