search

nothingisdead / npm-kraken-api

[DEPRECATED] NodeJS Client Library for the Kraken (kraken.com) API
Other
412 stars 188 forks source link

fix message signing #4

Closed thallium205 closed 10 years ago

nothingisdead commented 10 years ago

Hi,

Just a question... what does this fix? I'm not opposed to removing the helper functions, but it looks like you just condensed everything to a few lines. Is this doing something different that I missed?

Thanks!

thallium205 commented 10 years ago

Yeah the message signing simply doesn't work on the latest version of node.

nothingisdead commented 10 years ago

I didn't have a problem on either 0.10.24 or 0.10.25 with the existing code, or your code. The helper functions were kind of silly anyway, so I merged your code in and made some formatting changes.

Thanks!