search

nothingisdead / npm-kraken-api

[DEPRECATED] NodeJS Client Library for the Kraken (kraken.com) API
Other
412 stars 188 forks source link

Compatibilities of node versions #43

Open biko8 opened 7 years ago

biko8 commented 7 years ago

Please mention that this package is only compatible with node version 8. Because it uses async/wait functions.

OpinionatedGeek commented 7 years ago

I see this too. I like this API's approach, and it would be great if it could be compatible with Node 6.10 - that's the highest available Node version for my AWS stuff.

johnelkins commented 7 years ago

The node mean ami is severely outdated. I ended up spinning up an ubuntu 16.04 and installing node 8 myself. Might be worth the effort.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Geoff Taylor notifications@github.com Sent: Sunday, August 27, 2017 6:16:41 AM To: nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

I see this too. I like this API's approach, and it would be great if it could be compatible with Node 6.10 - that's the highest available Node version for my AWS stuff.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nothingisdead/npm-kraken-api/issues/43#issuecomment-325197776, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaCWVlDVq3nSLNgWzGzlTkcg72tEt1Uyks5scWw4gaJpZM4PDuhQ.

johnelkins commented 7 years ago

BTW... the api had been working perfectly for me. Thank you.

Get Outlook for iOShttps://aka.ms/o0ukef

From: John Elkins john.elkins@outlook.com Sent: Sunday, August 27, 2017 8:55:51 PM To: nothingisdead/npm-kraken-api; nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

The node mean ami is severely outdated. I ended up spinning up an ubuntu 16.04 and installing node 8 myself. Might be worth the effort.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Geoff Taylor notifications@github.com Sent: Sunday, August 27, 2017 6:16:41 AM To: nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

I see this too. I like this API's approach, and it would be great if it could be compatible with Node 6.10 - that's the highest available Node version for my AWS stuff.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nothingisdead/npm-kraken-api/issues/43#issuecomment-325197776, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaCWVlDVq3nSLNgWzGzlTkcg72tEt1Uyks5scWw4gaJpZM4PDuhQ.

johnelkins commented 7 years ago

Async/ await is a much better approach to promises. Makes for a very clean and succinct code base. I refactored an entire AWS api to use async/await and it was def worth it.

Get Outlook for iOShttps://aka.ms/o0ukef

From: John Elkins john.elkins@outlook.com Sent: Sunday, August 27, 2017 8:56:48 PM To: nothingisdead/npm-kraken-api; nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

BTW... the api had been working perfectly for me. Thank you.

Get Outlook for iOShttps://aka.ms/o0ukef

From: John Elkins john.elkins@outlook.com Sent: Sunday, August 27, 2017 8:55:51 PM To: nothingisdead/npm-kraken-api; nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

The node mean ami is severely outdated. I ended up spinning up an ubuntu 16.04 and installing node 8 myself. Might be worth the effort.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Geoff Taylor notifications@github.com Sent: Sunday, August 27, 2017 6:16:41 AM To: nothingisdead/npm-kraken-api Cc: Subscribed Subject: Re: [nothingisdead/npm-kraken-api] Compatibilities of node versions (#43)

I see this too. I like this API's approach, and it would be great if it could be compatible with Node 6.10 - that's the highest available Node version for my AWS stuff.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nothingisdead/npm-kraken-api/issues/43#issuecomment-325197776, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaCWVlDVq3nSLNgWzGzlTkcg72tEt1Uyks5scWw4gaJpZM4PDuhQ.

OpinionatedGeek commented 7 years ago

Yeah, I'd be happy to update my node version if I could but I'm using AWS Lambda and it only goes as high as Node 6.10.

I'm not against using async/await, BTW. I know other projects use Babel to compile the JavaScript they write to a lower version of JavaScript that more environments can use. How difficult would it be to put that in this project? (I did try using it to compile all my dependencies in node_modules, so that I could use this API, but it wasn't a great experience and I'm told it's not a great idea.)

Many thanks,

Geoff