search

nothingislost / obsidian-query-control

An experimental Obsidian plugin that adds controls to embedded queries
MIT License
278 stars 16 forks source link

Support "Backlinks pane in document" #4

Open bwydoogh opened 2 years ago

bwydoogh commented 2 years ago

Do you see a possibility that this plug-in also applies those modifications to the backlinks pane of a document (backlinks pane activated by the setting "Toggle backlinks in document")?

nothingislost commented 2 years ago

Hmm the backlinks element already has most of these controls natively. Is there something in particular you're looking for on backlinks?

bwydoogh commented 2 years ago

Your plug-in controls embedded queries, for example "show additional query result context by default"; I am missing a plug-in which also controls that backlinks pane. If I want to see more context in that backlinks pane, I need to indicate this every time again (when opening a new pane).

nothingislost commented 2 years ago

Ah I see. You want the ability to set defaults. Yeah, that should be doable. I'll consider this.

bwydoogh commented 2 years ago

Hi. Is this something you are still working on @nothingislost or is this not feasible?

efemkay commented 2 years ago

since it's not mentioned yet. i would love the backlinks to render markdown. just a toggle to enable it would be sufficient for me. sometimes i have backlinks mention that's within a header or list -- if it's not markdown rendered, it seems difficult to read. here's an example

image

isle9 commented 2 years ago

Ah I see. You want the ability to set defaults. Yeah, that should be doable. I'll consider this.

Just chiming in to check if you're still planning on doing this?

nothingislost commented 2 years ago

Give it a try https://github.com/nothingislost/obsidian-query-control/releases/tag/0.5.0

efemkay commented 2 years ago

wow. it works really well on my side. i've been using this plugin quite frequent. with this feature i think might as well have it in the community plugin so the general people can benefit from it

mblumberg commented 2 years ago

Nice one -- I've been looking for this functionality for quite a while...

nothingislost commented 2 years ago

Nice one -- I've been looking for this functionality for quite a while...

  • defaut settings for linked mention panels at the bottom of pages, and in the sidebar, work well.
  • But the plugin seems to have messed up embedded queries: the control bar appears embedded within the first list item rather than above the list; and clicking the "collapse" button links out to another page in my vault rather than collapsing the view (And the same applies when I try to create new queries)(using v0.5.0)

Hmm, what theme is that? Does it appear that way on the base theme?

At least for me, the nav bar is not inside of the results:

image

mblumberg commented 2 years ago

Ah, you're right: I do see that the nav bar is properly placed in the "default" theme. -- I'm using the Minimal theme, v5.3 (which is, fwiw, I think among the most popular themes)

nothingislost commented 2 years ago

Ah, you're right: I do see that the nav bar is properly placed in the "default" theme. -- I'm using the Minimal theme, v5.3 (which is, fwiw, I think among the most popular themes)

I use Minimal as well. By default, it does not appear to do what you show. Make sure you don't have any CSS snippets doing something weird with the header bar.

mblumberg commented 2 years ago

I don't have any CSS snippets or modifications. (My only other customizations are other plugins.)

mblumberg commented 2 years ago

(*Btw, I very much appreciate your support with this issue)

nothingislost commented 2 years ago

I just tried it with an empty vault, query control, and minimal and I don't see this issue so I'll need you to do some investigation on your end to determine what's causing this. Inspecting the element and looking for the style that's aligning it to the right may help track it down.

mblumberg commented 2 years ago

Inspecting the element and looking for the style that's aligning it to the right may help track it down.

Can you tell me how to do that, and then I can report back?

bwydoogh commented 2 years ago

Seems to work fine, except when I open a pane in a new window: a lot of new lines are created for every backlink.

See attached screenshot.

screenshot_20220727 _104731

Can you have a look @nothingislost ?

I don't have the issue (in new windows) when turning off this plugin.

bwydoogh commented 2 years ago

Can you have a look @nothingislost ?

Got it "fixed" using following CSS snippet

markdown-preview-view {
  height: inherit;
}