nothingislost / obsidian-query-control

An experimental Obsidian plugin that adds controls to embedded queries
MIT License
304 stars 20 forks source link

Fails to load in Obsidian 1.7.2 #53

Open bobbleheadjoe opened 2 months ago

bobbleheadjoe commented 2 months ago

After updating to Obsidian 1.7.2, the plugin no longer loads (returns a message that says "failed to load [obsidian-query-control]" and makes it impossible to open Settings or trigger commands).

Happens in my main vault and also in a blank test vault on macOS 14.6.1

Drakemoor commented 2 months ago

have the same issue.

paczkow commented 2 months ago

+1

Obsidian 1.7.2, macOS 14.6.1

auss commented 1 month ago

Same here, that's what I get in the console: app.js:1 Obsidian Developer Console plugin:obsidian42-brat:2378 loading BRAT app.js:1 Plugin failure: obsidian-query-control TypeError: t.onCopyResultsClick is not a function at q.getSearchExport (VM147 plugin:obsidian-query-control:6:7157) at q.eval (VM147 plugin:obsidian-query-control:6:5343) at Generator.next (<anonymous>) at r (VM147 plugin:obsidian-query-control:6:649) (anonymous) @ app.js:1 app.js:1 Plugin failure: obsidian-query-control TypeError: t.onCopyResultsClick is not a function at q.getSearchExport (plugin:obsidian-query-control:6:7157) at q.eval (plugin:obsidian-query-control:6:5343) at Generator.next (<anonymous>) at r (plugin:obsidian-query-control:6:649) (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 s @ app.js:1 Promise.then (async) l @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 e.enablePlugin @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 e.enablePluginAndSave @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 (anonymous) @ app.js:1 v @ app.js:1 (anonymous) @ app.js:1 t.setValue @ app.js:1 t.onClick @ app.js:1 obsidian.md-1727850796273.log

v1.7.3 MacOS 14.6.1

mretier commented 1 month ago

Same here

ll14m4n commented 1 month ago

hotfix: edit .obsidian/community-plugins.json and add it manually to the list:

[
  "obsidian42-brat",
  "obsidian-query-control"
]

restart, and it should load and work.

bobbleheadjoe commented 1 month ago

@ll14m4n appreciate the note, unfortunately that doesn't work though. It does load the plugin, but the functionality still isn't restored (i.e. no rendering as markdown).

ll14m4n commented 1 month ago

@bobbleheadjoe indeed. it still does not work for embedded queries, though it works for linked mentions at page bottom, which I use it for.

MDsza commented 1 month ago

Same here (Obsidian Installer version: v1.7.4): really bad, because all of my - per Templater-Script automatically generated - Daily Notes show many query-blocks, which are now (since my update to the actual Obsidian Installer Version) broken in every Daily Note. Looking now to use Dataview for a more stable base for this... hmmm.

websurfer93 commented 1 month ago

Same here. The plugin is indeed remarkable; however, it is unfortunate that the developers have ceased support for it.

kozziou commented 1 month ago

I've noticed that disabling and enabling the core plugin "Backlinks" restores the functionality of the embedded queries until restart.

websurfer93 commented 1 month ago

Anyone got any alternative plugin suggestions?

ll14m4n commented 1 month ago

for embedded queries alternative is Dataview.

for backlinks in documents there are no alternative plugins. but there is related feature request. https://forum.obsidian.md/t/retain-remember-status-of-backlinks-in-document/20341 please vote and leave a comment

reply2za commented 1 month ago

I was able to update Obsidian Query Control to work with the latest version of Obsidian.

https://github.com/reply2za/obsidian-query-control

websurfer93 commented 1 month ago

I was able to update Obsidian Query Control to work with the latest version of Obsidian.

https://github.com/reply2za/obsidian-query-control

Thank you, reply2za, for the recent update. I truly appreciate the improvements made. I was wondering if you could assist with another matter regarding the plugin.

Currently, highlighting is only applied to links that directly reference note names. However, links that use aliases (such as [[randomnote name|101]] do not receive highlighting. This makes it challenging to identify and access related information, especially when there are many references, which are often numerical. image This is particularly noticeable when the Render Markdown mode is disabled, as highlighting works correctly in that case. image If possible, please consider adding highlighting for aliased links in future versions of the plugin. This feature could greatly assist users in easily accessing the information they need and provide a better overall user experience.

Thank you for your hard work, and I hope this suggestion will be taken into consideration.

reply2za commented 1 month ago

For my understanding, are you saying that you would like rendered markdown text to be highlighted similar to how non-rendered markdown text is highlighted?

websurfer93 commented 1 month ago

Thank you for your clarification. Yes, I am indeed suggesting that the rendered markdown text should be highlighted in a manner akin to the highlighting of non-rendered markdown. The lack of highlighting in Render Markdown mode is something I believe should be addressed.

For my understanding, are you saying that you would like rendered markdown text to be highlighted similar to how non-rendered markdown text is highlighted?

websurfer93 commented 1 month ago

For example highlight number 8 in the image above, as shown in the example below.

These two images are identical. The Render Markdown mode is enabled at the top, yet, as you can see, # 8 is not highlighted.

MDsza commented 1 month ago

Thanks @reply2za for updating the plugin! Very appreciated. FYI: Failed to load plugin (0.7.8.)"obsidian-query-control" on my current Obsidian Installer version: v1.7.4.

reply2za commented 1 month ago

@websurfer93 That doesn't seem to have been a feature when displaying the "render markdown" and it will be tricky implementing it as the rendered markdown may not have the highlighted text visible once the markdown is rendered. Like how in your example you want the "8" to be highlighted while only the underlying text matches with the search query.

I will look into it but unfortunately can't make any promises as of right now.

reply2za commented 1 month ago

@MDsza I have come across that before. Can you try adding the plugin with a frozen version and setting that version as 0.7.8?

websurfer93 commented 1 month ago

@reply2za Thank you for your time and consideration. I appreciate the effort.

Pedro-Cataneo commented 1 month ago

@reply2za Tried to install with a frozen version and got this:

image

Thanks in advance for trying to keep this awesome plugin alive!

reply2za commented 1 month ago

@Pedro-Cataneo It looks like you're giving BRAT this repo, which is no longer maintained.

You should instead provide the fork I made with the patch & fixes: https://github.com/reply2za/obsidian-query-control

yfatahi commented 3 weeks ago

Dear @reply2za I would like to address a critical limitation in the plugin regarding alias support. The plugin does not seem to handle aliases highlights at all, despite their widespread use in many links. This omission is particularly problematic when dealing with lengthy paragraphs containing multiple links. Given that Obsidian's core plugin handles aliases effectively, this should be a solvable issue. Your assistance in resolving this functionality gap would be greatly appreciated by the community. Thank you for your consideration.

I was able to update Obsidian Query Control to work with the latest version of Obsidian. https://github.com/reply2za/obsidian-query-control

Thank you, reply2za, for the recent update. I truly appreciate the improvements made. I was wondering if you could assist with another matter regarding the plugin.

Currently, highlighting is only applied to links that directly reference note names. However, links that use aliases (such as [[randomnote name|101]] do not receive highlighting. This makes it challenging to identify and access related information, especially when there are many references, which are often numerical. image This is particularly noticeable when the Render Markdown mode is disabled, as highlighting works correctly in that case. image If possible, please consider adding highlighting for aliased links in future versions of the plugin. This feature could greatly assist users in easily accessing the information they need and provide a better overall user experience.

Thank you for your hard work, and I hope this suggestion will be taken into consideration.