search

nothingislost / obsidian-workspaces-plus

Quickly switch and manage Obsidian workspaces
GNU General Public License v3.0
198 stars 6 forks source link

Console error when doing Shift + Enter to save as new workspace name #5

Closed GitMurf closed 3 years ago

GitMurf commented 3 years ago

I typed "TESTING" into the modal without having a workspace called that and pressed Shift + Enter and it gave this console error.

image

GitMurf commented 3 years ago

Using v0.0.2

GitMurf commented 3 years ago

Now that I look at this, it may have nothing to do with your plugin and instead have to do with the native Obsidian workspaces and issues they may have with sliding panes?

nothingislost commented 3 years ago

Hmmm, can't replicate it, even with sliding panes. Let me know if it's still an issue on 0.0.3 and if so, how to replicate.

GitMurf commented 3 years ago

I'm working on it. Disabling one plugin at a time ;-p I think it was a plugin which don't play nicely if proper "state" validation/tracking isn't in place. Since Workspace changes trigger a whole new layout, I assume it is a plugin that depends on the initial load/layout of obsidian. I'll see what the culprit is and let you know.

nothingislost commented 3 years ago

Does it happen only on shift+enter? Shift+enter saves the current workspace as the selected item or whatever string has been typed into the input box. Once saved, it'll load that same workspace, triggering a layout change.

nothingislost commented 3 years ago

Are we good to close this @GitMurf ?