search

nothings / single_file_libs

List of single-file C/C++ libraries.
8.88k stars 584 forks source link

Duplication for catch, adding catch2 #95

Closed campisano closed 5 years ago

nothings commented 6 years ago

A few issues:

  1. You have an editor set to delete trailing whitespace or something, which is causing a lot of extra junk in the diffs (look at 'files changed' tab in this thread). Can you submit that as a separate PR with no real changes, just the whitespace? You shouldn't need to change these ones, once I merge that one these should be clearer.

  2. What is up with these titles ("Close #93", "Closed #94")?

campisano commented 6 years ago

1) sure, I will change that 2) I forgot to define a title, and the pull request automatically get the commit text I think. I will rename them

campisano commented 6 years ago

Mmm probably there is no need to close...

campisano commented 6 years ago

removed trailing space restored