search

nothub / mrpack-install

Modrinth Modpack server deployment
https://pkg.go.dev/github.com/nothub/mrpack-install
MIT License
128 stars 9 forks source link

Command to extract and install client files. #16

Open nothub opened 1 year ago

nothub commented 1 year ago

As seen in #15.

limejet commented 1 year ago

It would be neat if this feature could be implemented with Automodpack in mind by extracting both client and server stuff into different directories. That way they can be served to the client and a user would only need a very basic setup to join an Automodpack-enabled server.

nothub commented 12 months ago

@limejet thanks for your input!

I have never used AutoModpack, are there some specific things I have to care about or is it sufficient or is it sufficient if I expose 2 cli flags to defined the 2 paths?

limejet commented 12 months ago

By default automodpack just sends files in mods/ and config/ (configurable in automodpack/automodpack-server.json) as well as everything in automodpack/host-modpack. This allows for sending shaderpacks and things of that nature to the client without polluting the server instance with unused files.

A --client flag should be enough to get a working setup, because it could be done in two steps:

  1. mrpack-install <pack-name> /path/to/minecraft/ to set up the instance
  2. something like mrpack-install <pack-name> --client /path/to/minecraft/automodpack/host-modpack

Maybe with the addition of a flag like --data-only (or some better name) that would prevent files not specified in the mrpack (server.jar and such) from being downloaded.

For reference, the way I've set up my server is that players download a "base.mrpack" that just contains quilt, automodpack, and the server address. An first join they get everything else, and this way I only have to update the base pack whenever there's an update to the game, the loader, or automodpack.

nothub commented 12 months ago

Okay this sounds good, I gonna try to implement this in a clean way that is nice to use.