search

nothub / mrpack-install

Modrinth Modpack server deployment
https://pkg.go.dev/github.com/nothub/mrpack-install
MIT License
128 stars 9 forks source link

File support for update command #23

Open limejet opened 11 months ago

limejet commented 11 months ago

I use local packs for my server since i distribute mods with automodpack rather than by having people download the pack manually. I have a script that runs mrpack-install latest-pack.mrpack on every restart, and this worked until i replaced a mod with a mutually incompatible one. it was at this point i realized that the program only deletes files when running update, and that the update command has no code path for files. Could this capability be added?

nothub commented 11 months ago

I am not sure if I understand correctly.

You replaced a mod with a mutually incompatible one. You mean mutually incompatible by definition of the mods in their respective mod configuration files?

the program only deletes files when running update, and that the update command has no code path for files

I am also not sure if I understand this correctly. What do you mean with :

the program only deletes files when running update, and that the update command has no code path for files

Could you describe what you suspected the tool to do and what it actually did?

limejet commented 11 months ago

What i expected to happen when running mrpack-install /path/to/my-pack.mrpack on an existing instance was that the tool would make the installation match the mrpack specification by removing mods and configs not included in the pack definition. Instead, it just installs on top, leaving old files as they were.

My understanding for update was that maybe a normal install would not care about existing files but an update would, but now that i'm reading through the docs i realize that's now what it does. The name of the issue is a consequence of my misunderstanding.

nothub commented 9 months ago

Hey @limejet , sorry that I took so long to answer here. What you are describing makes me wonder if the current update command workflow was ever implemented in a sane way :see_no_evil:

I am in the process of rewriting the update workflow currently. I have described the planned behaviour in : #39

Mods that were included in the packs definition in the past but are not included anymore when the update command is run should be removed from the mods directory. From what I wrote in #39, this is also what I had in mind.

The workflow in #39 is not finalized yet and is still subject to change.