search

nothub / mrpack-install

Modrinth Modpack server deployment
https://pkg.go.dev/github.com/nothub/mrpack-install
MIT License
128 stars 9 forks source link

Overrides fail on local modpack #40

Closed MrNavaStar closed 4 months ago

MrNavaStar commented 5 months ago

I have a modpack that my friend made, and when I try to create a server using this tool the overrides fail to extract.

Running this command: Screenshot from 2024-03-03 17-28-13 Results in this: Screenshot from 2024-03-03 17-28-32

Not a huge issue as the overrides can be extracted manually, but would be awesome if It can be addressed. Cheers! Awesome tool btw!

nothub commented 5 months ago

Hey @MrNavaStar , thanks for your report!

Can you provide an example mrpack file for me to test?

MrNavaStar commented 5 months ago

Sure thing! This is the one I used. I Just renamed the file from mrpack to zip so It would let me upload it

Wings_Of_Adventure_1.0.0.zip

nothub commented 5 months ago

I just tested and can confirm your issue. The issue happens in the v0.17.0-indev pre-release. The current stable release v0.16.10 seems to be fine.

Please use the current stable release for now. The issue will be fixed in a future release.

I will keep the Ticket open to track this bug.

MrNavaStar commented 5 months ago

Oh I didn't realize I was on a beta build. Thanks!

nothub commented 4 months ago

I just published a new pre-release version v0.17.0-beta. With that version I can now successfully install the mrpack file you provided.

@MrNavaStar can you verify that the issue is also solved for you when using the new version?

nothub commented 4 months ago

I tested again on linux amd64 and the issue is fixed. If you experience another issue related to this ticket, just reopen it.