search

noties / Markwon

Android markdown library (no WebView)
https://noties.io/Markwon/
Apache License 2.0
2.74k stars 309 forks source link

Bump commonmark to 0.17.+ #341

Open yvan-botella opened 3 years ago

yvan-botella commented 3 years ago

Since commonmark@1.7.0 (also 1.7.1 available) https://github.com/commonmark/commonmark-java/releases/tag/commonmark-parent-0.17.0

Maven groupId has changed, which when using Commonmark and Markwon cause Duplicate class … found in modules

jetified-commonmark-0.13.0 (com.atlassian.commonmark:commonmark:0.13.0) and
jetified-commonmark-0.17.1 (org.commonmark:commonmark:0.17.1)

Is it possible to bump version of Commonmark to 0.17.1 ?

noties commented 3 years ago

Hello @yvan-botella ,

yes, updating commonmark-java version is definitely on the roadmap. Unfortunately it requires some effort, for which I cannot allocate enough time right now.

As a possible workaround I think that you can try forcing updated dependencies. Try excluding com.atlassian.commonmark modules from all markdown dependencies and then explicitly adding org.commonmark modules in your project dependencies block. A possible way of excluding is discussed in #148 . Unfortunately this way there is no guarantee that there are no conflicts, so please check that your application behaves properly in runtime (if it compiles at all)

rakaadinugroho commented 6 months ago

i try to exlude com.atlassian.commonmark to all markwon deps, got crash in runtime @noties