notifme / notifme-sdk

A Node.js library to send all kinds of transactional notifications.
https://notifme.github.io/www/
MIT License
1.94k stars 149 forks source link

added PLIVO as a SMS service provider #10

Closed Abhishek-plivo closed 7 years ago

Abhishek-plivo commented 7 years ago

Hey, this is Abhishek from Plivo . We saw this cool npm package and thought of adding Plivo as a SMS provider in this module . Please find the commit details mentioned below as well review the commits :-

BDav24 commented 7 years ago

Hi @Abhishek-plivo thanks for your pull request! We replaced request dependency by node-fetch, but don't worry I'll update your code.

BDav24 commented 7 years ago

https://github.com/notifme/notifme-sdk/commit/67ea41be90afebf8443b685971bda06764c6c082

Abhishek-plivo commented 7 years ago

Thanks, @BDav24 . I see Travis CI build failed . Does it need to change something in our commits ?

BDav24 commented 7 years ago

Everything's okay: https://travis-ci.org/notifme/notifme-sdk/builds/265611020 (I forgot to tag my commit with the reference of this PR, that's why it doesn't appear here)

Abhishek-plivo commented 7 years ago

cool , thanks