search

notifme / notifme-sdk

A Node.js library to send all kinds of transactional notifications.
https://notifme.github.io/www/
MIT License
1.94k stars 150 forks source link

Introducing Whatsapp support #160

Closed enricodeleo closed 1 month ago

enricodeleo commented 2 months ago

Introducing the first step towards the desire the community is sharing: whatsapp messages!

I tried to follow conventions introducing this new channel and already implemented the first provider: Infobip. I could test only template messages but it should work for conversational messages too. Reference docs is here https://www.infobip.com/docs/api/channels/whatsapp/whatsapp-outbound-messages/send-whatsapp-template-message

Docs and example code are not ready yet, but help is welcomed.

BDav24 commented 2 months ago

Thanks for the PR, I'll check it next week.

BDav24 commented 1 month ago

@enricodeleo I added some tests, fixed linting, and also changed WhatsappRequestType, what do you think?

https://github.com/notifme/notifme-sdk/pull/166/files

enricodeleo commented 1 month ago

Looks great @BDav24 and shame on me I didn't do the job as good as you did, since the beginning! (In my defence it was the first time I contributed and had to learn hands-on the architecture of the library :))

BDav24 commented 1 month ago

Looks great @BDav24 and shame on me I didn't do the job as good as you did, since the beginning! (In my defence it was the first time I contributed and had to learn hands-on the architecture of the library :))

Not at all, you did well :+1:

BDav24 commented 1 month ago

Closed in favor of https://github.com/notifme/notifme-sdk/pull/166