search

notifme / notifme-sdk

A Node.js library to send all kinds of transactional notifications.
https://notifme.github.io/www/
MIT License
1.94k stars 149 forks source link

Add fromName to sendgrid options #21

Closed nums closed 6 years ago

BDav24 commented 6 years ago

Currently "fromName" must be given in the from string: "name <email>". I had plans to add support for this, but it should be implemented in all the email providers.

nums commented 6 years ago

Sendgrid has many parameters : https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/index.html#-Request-Body-Parameters

Is it a good idea of having an additional "extra-data" to use all possible parameters of a provider? We can have "from, to, subject, html" wich are mandatory for email and an optional "extra" field for specific provider data