Adds voice provider. Currently only Twilio, NotificationCatcher, and custom supported

notifme / notifme-sdk

A Node.js library to send all kinds of transactional notifications.

https://notifme.github.io/www/

MIT License

1.94k stars 149 forks source link

Adds voice provider. Currently only Twilio, NotificationCatcher, and custom supported #48

Closed armiiller closed 6 years ago

armiiller commented 6 years ago

What is the acceptance on the tests?

I am getting: Jest: "global" coverage threshold for statements (100%) not met: 96.41% Jest: "global" coverage threshold for branches (100%) not met: 94.56%

BDav24 commented 6 years ago

Hi @armiiller Thanks for the PR! Configuration for coverage is 100% (because it's a small project :)), but this can be fixed later. I'll try to review the code next week.

armiiller commented 6 years ago

@BDav24 - Did you get a chance to check this out?

BDav24 commented 6 years ago

Sorry, I had a big week. I'm on it.