Add ability to use custom channels

p16 commented 6 years ago

Hi there, I was using notifme-sdk and needed a way to add custom channels. The idea I need to implement is to let users define their own channels/providers. That's why I've not opened a new ticket about a specific channel to be implemented.

To make notifme-sdk accept custom channels I've:

added a default to the providers factory that just return the config (as the other factories do).
added the custom channels to the sender channels list
updated the NotificationRequestType so that is can accepts also other properties

Let me know if this PR make sense and if there are things you may want to change to make this better/more compatible with the library.

Thanks for your work on this!

BDav24 commented 6 years ago

Hi @p16 Thanks for the pull request! I'll review as soon as I can (I don't know when though).

BDav24 commented 5 years ago

Sorry for the delay, I completely forgot the review :/

p16 commented 5 years ago

@BDav24 no problem! Thanks for the merge! :)

notifme / notifme-sdk

Add ability to use custom channels #57