search

notifme / notifme-sdk

A Node.js library to send all kinds of transactional notifications.
https://notifme.github.io/www/
MIT License
1.94k stars 150 forks source link

Added Mandrill support #58

Closed fluciotto closed 5 years ago

fluciotto commented 5 years ago

Hi,

I just added Mandrill support through their API and the nodemailer-mandrill-transport module.

BDav24 commented 5 years ago

Hi @fluciotto, thanks for the pull request! I'm trying not to add too many dependencies (the goal would be to remove some), so would you like to try to call directly the mandrill api with http calls (with node-fetch)?

fluciotto commented 5 years ago

Hi,

Ok, i will update the pull request soon.

fluciotto commented 5 years ago

Hi @BDav24,

Did you check the PR update? What do you think about it?

BDav24 commented 5 years ago

Ho you finished, I'll try to check it by the end of the week, thanks!

BDav24 commented 5 years ago

Hi @fluciotto Still working on the review (https://github.com/notifme/notifme-sdk/commit/3b767664ff0d29288f509382c392c477aaef5f54), but the account I created to test was blocked because of "conflict with their Acceptable Use Policy " (and I didn't have the time to send any email)... I'll keep you posted.

BDav24 commented 5 years ago

Hi @fluciotto sorry for the delay but they never unblocked my account :/ Anyway it's merged: https://github.com/notifme/notifme-sdk/releases/tag/v1.8.0