Closed SebastianStehle closed 1 year ago
https://github.com/notifo-io/sdk-xamarin/blob/f5356a83edde7b164151a69aa6db4983c707cd22/sdk/Notifo.SDK.FirebasePlugin/NotifoPushNotificationHandler.android.cs#L102
The current approach blocks the thread. I am not sure if this can cause issues. I have found this:
https://stackoverflow.com/questions/24840282/load-image-from-url-in-notification-android
There should be overload for streams which consumes less memory: https://github.com/notifo-io/sdk-xamarin/blob/beac7a59b3a8dd99dc728ca6a087040636f43c59/sdk/Notifo.SDK/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs#L221. I also think that the cache is useless here.
Issue 1
https://github.com/notifo-io/sdk-xamarin/blob/f5356a83edde7b164151a69aa6db4983c707cd22/sdk/Notifo.SDK.FirebasePlugin/NotifoPushNotificationHandler.android.cs#L102
The current approach blocks the thread. I am not sure if this can cause issues. I have found this:
https://stackoverflow.com/questions/24840282/load-image-from-url-in-notification-android
Issue 2
There should be overload for streams which consumes less memory: https://github.com/notifo-io/sdk-xamarin/blob/beac7a59b3a8dd99dc728ca6a087040636f43c59/sdk/Notifo.SDK/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs#L221. I also think that the cache is useless here.