search

notifo-io / sdk-xamarin

6 stars 1 forks source link

Fix/completed collection error #25

Open xamplum opened 1 year ago

xamplum commented 1 year ago

… additions". by removing "queue.CompleteAdding();" from completeAsync for logout.

This issue happened if user logged out and directly logged back in again without closing the app first. If we mark the collection as "completed" we cannot add the command to register.

I tested it locally with our app. Login -> Logout -> login worked without any issues. Token got updated

SebastianStehle commented 1 year ago

This cannot work. Because we dispose everything then. The question is, if we even have to call the CompleteAsync() here.

xamplum commented 1 year ago

@SebastianStehle i think we do need it. Because otherwise the token is not deleted

SebastianStehle commented 1 year ago

Then you have to either create a new queue after that or you have to reimplement the completion mechanism with something more sophisticated. We can discuss this over a call.

xamplum commented 1 year ago

you know how to reach me :-). Feel free to contact me as soon as you have time