notify-rs / notify

🔭 Cross-platform filesystem notification library for Rust.
https://docs.rs/notify
2.77k stars 222 forks source link

Prevent installing `crossbeam-channel` with `default-features="false"` #550

Closed LeoniePhiline closed 10 months ago

LeoniePhiline commented 1 year ago

Debouncers used to install crossbeam-channel, due to keeping notify's default features enabled even if their own default features were disabled.

With this change, crossbeam-channel will no longer be installed if notify-debouncer-* as well as notify are installed with default-features = false

Fixes #549

LeoniePhiline commented 1 year ago

Thanks for running the workflow!

I have adjusted the pull request with the following:

LeoniePhiline commented 1 year ago

Workflow run 643 can be cancelled. See intermediate version missing a job condition predicate.

Workflow run 644 can be run.

0xpr03 commented 1 year ago

This will be part of #525

LeoniePhiline commented 11 months ago

Hi @0xpr03

Thanks for your review!

I have added an answer to your question, and in turn asked a clarifying question about your comment.