search

notify-rs / notify

🔭 Cross-platform filesystem notification library for Rust.
https://docs.rs/notify
2.76k stars 222 forks source link

Relax windows-rs version requirement #574

Closed simonask closed 5 months ago

simonask commented 8 months ago

notify currently asks for windows 0.48.0, which prevents Cargo from using newer version of the crate.

The only reason to stay on windows 0.48.0 is that it's the last version to support Rust 1.48, but notify uses edition = "2021", which was first supported i Rust 1.56.

Many crates in the ecosystem depend on the windows crate, and it adds quite a bit to compile times. This is a problem because multiple versions of the crate end up getting compiled. In my case, I currently have 4 versions (!!) of windows in my build, and notify is by far the oldest.

Relaxing the requirement to just 0.48 (without the patch version) should allow Cargo to select newer versions of the crate.

waywardmonkeys commented 6 months ago

@simonask Changing from 0.48.0 to 0.48 won't help here. The newer version being used is 0.52 and that won't get used automatically due to how versions under 1.0 are handled by cargo.

There are already a couple of PRs that update this to 0.52, so hopefully they'll land and we'll get a v7.

simonask commented 5 months ago

Ah, I see, that's unfortunate. I'm closing this issue now, since windows-rs seems unlikely to reach 1.0 anytime soon. Feel free to reopen if you want to keep this around. :-)