0xpr03
commented
4 months ago Maybe @dfaust has a faster answer what the debouncer logic does here. Would have to dig around first how we flatten this joyride of renames to have backups, especially with the timing here.
create test.blend@ (new content)
delete test.blend1 (delete backup)
rename test.blend -> test.blend1 (move current to backup)
rename test.blend@ -> test.blend (move new to current)Hard to say what you would even want to get reported here. Delete test.blend1, Rename test.blend -> test.blend1, Modify test.blend in that succession would probably be the closest to the truth. Even though modify test.blend, test.blend1 would be true too - in the spirit of what blender really does at the end for the asset recompilation.
dfaust
Sorseg
System details
Linux host 6.8.0-76060800daily20240311-generic #202403110203~1713206908~22.04~3a62479 SMP PREEMPT_DYNAMIC Mon A x86_64 x86_64 x86_64 GNU/Linuxrustc --version:rustc 1.77.2 (25ef9e3d8 2024-04-09)notify-debouncer-full v0.3.1Cargo tree
ext4 (rw,relatime)What you did (as detailed as you can)
Run the example code, then open an existing file
test.blendin blender and overwrite it with a new version.What I ran
```rust use std::path::Path; use std::time::Duration; use notify_debouncer_full::{DebounceEventResult, new_debouncer}; use notify_debouncer_full::notify::{RecursiveMode, Watcher}; fn main() { println!("Hello, world!"); // Select recommended watcher for debouncer. // Using a callback here, could also be a channel. let mut debouncer = new_debouncer(Duration::from_secs(2), None, |result: DebounceEventResult| { match result { Ok(events) => events.iter().for_each(|event| println!("{event:?}")), Err(errors) => errors.iter().for_each(|error| println!("{error:?}")), } }).unwrap(); // Add a path to be watched. All files and directories at that path and // below will be monitored for changes. debouncer.watcher().watch(Path::new("."), RecursiveMode::Recursive).unwrap(); // Add the same path to the file ID cache. The cache uses unique file IDs // provided by the file system and is used to stich together rename events // in case the notification back-end doesn't emit rename cookies. debouncer.cache().add_root(Path::new("."), RecursiveMode::Recursive); std::thread::sleep(Duration::from_secs(100000000)); } ```What you expected
I expected to read a series of events that would indicate that the
test.blendnow contains the new data, as this is what bevy relies upon to reload the assets.What happened
strace of blender saving a file
``` 20:45:43.021143 openat(AT_FDCWD, "<...>/test.blend@", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 28 20:45:43.023758 unlink("<...>/test.blend1") = 0 20:45:43.024196 rename("<...>/test.blend", "<...>/test.blend1") = 0 20:45:43.024412 rename("<...>/test.blend@", "<...>/test.blend") = 0 ```Result
``` DebouncedEvent { event: Event { kind: Create(File), paths: ["<...>/./test.blend"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }, time: Instant { tv_sec: 28469, tv_nsec: 182994437 } } DebouncedEvent { event: Event { kind: Access(Close(Write)), paths: ["<...>/./test.blend"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }, time: Instant { tv_sec: 28469, tv_nsec: 185258534 } } DebouncedEvent { event: Event { kind: Remove(Any), paths: ["<...>/./test.blend1"], attr:tracker: None, attr:flag: None, attr:info: None, attr:source: None }, time: Instant { tv_sec: 28469, tv_nsec: 185991873 } } DebouncedEvent { event: Event { kind: Modify(Name(Both)), paths: ["<...>/./test.blend", "<...>/./test.blend1"], attr:tracker: Some(10280), attr:flag: None, attr:info: None, attr:source: None }, time: Instant { tv_sec: 28469, tv_nsec: 185991873 } } ```The resulting list of events confuses bevy into thinking there is only the
.blend1file, as the last event returned is the rename. Which is not what actually happens to the filesystem.Thank you for maintaining this :heart: !