notify-rs / notify

🔭 Cross-platform filesystem notification library for Rust.
https://docs.rs/notify
2.76k stars 222 forks source link

Fix blender save #590

Open dfaust opened 6 months ago

dfaust commented 6 months ago

The debouncer is getting increasingly complicated. It took me a few tries to design this change as defensively as possible. I hope it doesn't break anything.

This PR is based on #569.

dfaust commented 3 months ago

I think we will need way more documentation to keep this usable in the future

Agreed. I will add more comments as I work on it.

0xpr03 commented 3 months ago

We can merge this for now, if you want. I just would like to document this, because I fear we will otherwise have a ton of regressions in the future.

dfaust commented 3 months ago

Then let's not merge it for now. I will document it better and try to fix the original issue.

While the PR does improve the behavior of the debouncer, it doesn't actually fix the blender issue.