search

notify-rs / notify

🔭 Cross-platform filesystem notification library for Rust.
https://docs.rs/notify
2.77k stars 222 forks source link

Fix advisory #652

Closed BenjaminBrienen closed 2 weeks ago

BenjaminBrienen commented 2 weeks ago

Fixes a security advisory. instant is no longer maintained, but there is a drop-in replacement. image

dfaust commented 2 weeks ago

Thanks. Can you please add a changelog entry:

## notify-types 2.0.0 (unreleased)

- CHANGE: replace instant crate with web-time **breaking**
bushrat011899 commented 2 weeks ago

Just calling out that instant is BSD-3-Clause licenced, while web-time is MIT/Apache-2.0. I don't know if that's an issue for this project (came here from Bevy) but wanted to make sure everyone's aware.

dfaust commented 2 weeks ago

@bushrat011899 Thanks for the info. But I don't see an issue with MIT/Apache-2.0.

dfaust commented 2 weeks ago

@bushrat011899 Is there a Bevy issue related to this?

bushrat011899 commented 2 weeks ago

@dfaust no @BenjaminBrienen just noticed it and let us know on the Discord. They're very quick with this stuff haha.

BenjaminBrienen commented 2 weeks ago

@dfaust done! let me know if it is in the wrong spot or something.

dfaust commented 2 weeks ago

Thanks