fix: could not deserialize unique_id

RandomUser14 commented 1 year ago

Description

Added support for unique_id property type to fix deserialize issue.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

KoditkarVedant commented 1 year ago

@RandomUser14 could you resolve the CodeFactor warnings.

alfadormx commented 1 year ago

Hello I am having issues with the unique_id as well and I see this PR could fix this issue @RandomUser14 @KoditkarVedant , are you planning on merging this PR anytime soon? if not, which release version of Notion-dotnet shall I use ? How come this PR has been since July? Thanks for your kind help.

KoditkarVedant commented 1 year ago

@alfadormx I'll take a look this weekend and release the latest version. Could you please take a look at one failing check.

lejafo commented 12 months ago

Hi! what's the status of this PR?

notion-dotnet / notion-sdk-net