search

notion-enhancer / notion-repackaged

notion executables with the notion-enhancer embedded & a vanilla port of the official app to linux
https://notion-enhancer.github.io/getting-started/installation
MIT License
908 stars 52 forks source link

Object.hasOwn is not a function in mermaid diagrams in notion-repackaged #114

Open dolfandringa opened 11 months ago

dolfandringa commented 11 months ago

What is happening? When looking at a mermaid diagram (rendered through a code snippet of language mermaid) I see the mermaid code, but when its rendering the image, it give a javascript error Unknown Error: TypeError: Object.hasOwn is not a function.

Checking the error, it looks like Object.hasOwn is only supported since nodejs 16.9, but looking in this repo, notion-repackaged seems to use nodejs 14.17.1. This would explain the issue.

If upgrading nodejs isn't an option, there also seems to be a polyfill for it that could maybe solve it? https://github.com/es-shims/Object.hasOwn

What should be happening? The mermaid diagram should be rendered.

Screenshots (if applicable): Issue in notion-repackaged: image

Its fine in the browser: image

Operating system/browser name & version: Fedora Linux 38

notion-enhancer and/or notion-repackaged version: notion-app-2.0.18-1.x86_64

notion-enhancer configuration (enabled/disabled mods and their settings):

reopencil commented 11 months ago

me too

sheiun-xu commented 10 months ago

Same on Ubuntu 22.04, notion-app

Yu-Xiao-Sheng commented 7 months ago

我也是，在Ubuntu22.04上，notion-app-enhanced

iliabaranov commented 6 months ago

same :(