search

notional-labs / cosmosia

Cosmos Infrastructure Automation
54 stars 26 forks source link

Add update config script #608

Closed hqdNotional closed 4 months ago

hqdNotional commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The update_config.sh script has been enhanced to better manage chain configurations, focusing on RPC and snapshot functionalities. It now includes more robust options for updating environment variables, handling snapshot configurations, and modifying start scripts based on user inputs.

Changes

File Path Change Summary
rpc/scripts/update_config.sh Enhanced to manage RPC and snapshot configurations more effectively.

Poem

🐇✨
In the burrow of code, under digital skies,
A script was tweaked, a new dawn lies.
Snapshots and chains, in harmony they spin,
Updates unfurl, let the new begin!
🌟🌿

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6955a208182f643a8a1fa39d3e5d7cf0927882b2 and 4b89b37634917675c7c8bcc10227ddcaaf8342a8.
Files selected for processing (1) * rpc/scripts/update_config.sh (1 hunks)
Additional Context Used
ShellCheck (36)
rpc/scripts/update_config.sh (36)
[style] 8-8: Use $(...) notation instead of legacy backticks `...`. --- [info] 23-23: Double quote to prevent globbing and word splitting. --- [info] 30-30: Double quote to prevent globbing and word splitting. --- [info] 32-32: Not following: ./env.sh was not specified as input (see shellcheck -x). --- [info] 32-32: Double quote to prevent globbing and word splitting. --- [warning] 48-48: chain_name is referenced but not assigned. --- [info] 48-48: Double quote to prevent globbing and word splitting. --- [warning] 59-59: config is referenced but not assigned. --- [info] 75-75: Double quote to prevent globbing and word splitting. --- [warning] 78-78: snapshot_storage_node is referenced but not assigned. --- [info] 89-89: Double quote to prevent globbing and word splitting. --- [info] 89-89: Double quote to prevent globbing and word splitting. --- [info] 89-89: Double quote to prevent globbing and word splitting. --- [info] 92-92: Double quote to prevent globbing and word splitting. --- [warning] 95-95: version is referenced but not assigned. --- [warning] 96-96: daemon_name is referenced but not assigned. --- [warning] 97-97: node_home is referenced but not assigned. --- [warning] 98-98: minimum_gas_prices is referenced but not assigned. --- [warning] 99-99: start_flags is referenced but not assigned. --- [warning] 100-100: db_backend is referenced but not assigned. --- [warning] 101-101: go_version is referenced but not assigned. --- [warning] 102-102: build_script is referenced but not assigned. --- [warning] 105-105: Quote this to prevent word splitting. --- [info] 119-119: Double quote to prevent globbing and word splitting. --- [info] 119-119: Double quote to prevent globbing and word splitting. --- [info] 122-122: Double quote to prevent globbing and word splitting. --- [warning] 130-130: snapshot_node is referenced but not assigned. --- [warning] 133-133: snapshot_prune is referenced but not assigned. --- [warning] 139-139: Quote this to prevent word splitting. --- [error] 157-157: In functions, use return instead of continue. --- [error] 159-159: In functions, use return instead of continue. --- [info] 167-167: Double quote to prevent globbing and word splitting. --- [info] 167-167: Double quote to prevent globbing and word splitting. --- [info] 167-167: Double quote to prevent globbing and word splitting. --- [info] 170-170: Double quote to prevent globbing and word splitting. --- [error] 180-180: In functions, use return instead of continue.
Additional comments not posted (1)
rpc/scripts/update_config.sh (1)
`14-18`: Function `check_chain_status` looks good and serves its purpose effectively.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
baabeetaa commented 4 months ago

looks good, best to test it on a rpc and a snapshot node. Remember to backup the env file. Or backup to .env.bk instead of removing it.