search

notionparallax / ShadowWolf

A mini ERP type app to capture people, projects and their relationships.
GNU General Public License v2.0
1 stars 6 forks source link

Double quotation mark does not work properly if new line is used in Testimonial #802

Open DanielMok opened 9 years ago

DanielMok commented 9 years ago

The closing quotation mark does not align with the end of the sentence if two lines/paragraphs are used in testimonial.

Closing quotation mark went to the bottom of the sentence image

Closing quotation mark following the end of the sentence image

@hinds89 Just happened to have a testimonial that has two paragraphs for Northern Beaches Hospital PPP (S1411003). Do we standardize all testimonials to be single paragraph?

notionparallax commented 9 years ago

are you sure that there isn't a spare line break on the end of that quote

On 24 August 2015 at 17:38, DanielMok notifications@github.com wrote:

The closing quotation mark does not align with the end of the sentence if two lines/paragraphs are used in testimonial.

Closing quotation mark went to the bottom of the sentence [image: image] https://cloud.githubusercontent.com/assets/12906825/9434801/9f034660-4a85-11e5-84fb-5fd98addd2ab.png

Closing quotation mark following the end of the sentence [image: image] https://cloud.githubusercontent.com/assets/12906825/9434821/c063a4d0-4a85-11e5-8fd1-72d1e20a1f64.png

@hinds89 https://github.com/hinds89 Just happened to have a testimonial that has two paragraphs for Northern Beaches Hospital PPP (S1411003). Do we standardize all testimonials to be single paragraph?

— Reply to this email directly or view it on GitHub https://github.com/notionparallax/ShadowWolf/issues/802.

DanielMok commented 9 years ago

@notionparallax I am quite sure

hinds89 commented 9 years ago

The problem is there are <div> </div> tags around the second paragraph (without this element I think there is only one paragraph even if you add line breaks) A workaround - use a <br> tag between paragraphs and then quote is fine, I have fixed it for this project only (probably need a way to make sure this always happens when editing Testimonials)