notishell / smali

Automatically exported from code.google.com/p/smali
0 stars 0 forks source link

Revison 96b803c8821b "Add support for version 36 dex files" is right? #110

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What seems to be the problem?
If I set option "-a 14", apiSet = true and apiLevel = 14.
But, I will not set option, apiSet = false and apiLevel = 14.

As a result, "-a 14" option makes header "36".
Non option heaer is "35".

The header "36" makes boot loop in ICS 4.0.2.

What is the exact smali/baksmali command that you ran?
> java -jar smali.jar -a 14 -o classes.dex out

What version of smali/baksmali are you using? What rom are you working
from?
1.3.2

What is the airspeed velocity of an unladen swallow?
I don't know.

Please provide any additional information below: error messages, symptoms,
etc.

Original issue reported on code.google.com by jin.ada...@gmail.com on 26 Feb 2012 at 1:39

GoogleCodeExporter commented 9 years ago
Hmm. You don't really need to use -a when re-assembling, unless you need the 
new jumbo opcodes. Try it without -a.

Original comment by jesusfreke@jesusfreke.com on 26 Feb 2012 at 4:45

GoogleCodeExporter commented 9 years ago
Yes, of course.
I did not set -a option to avoid this issue.

But this behavior is very strange.
If you change -a default value I will set -a option to 14.

Original comment by jin.ada...@gmail.com on 26 Feb 2012 at 5:05

GoogleCodeExporter commented 9 years ago
Yeah, after taking a look at how I implemented it again, there is some 
weirdness there. I'm not sure the best way to handle it though.

At some point, I will probably try to handle the api level in smali in a more 
transparent way by default - choose an appropriate api level (and dex version 
number) based on the opcodes that are present.

Original comment by jesusfreke@jesusfreke.com on 26 Feb 2012 at 8:46