notiz-dev / notiz

Frontend for notiz.dev. Built with Angular and Scully 👋
https://notiz.dev
67 stars 9 forks source link

feature/tailwind 2 #126

Closed marcjulian closed 3 years ago

marcjulian commented 3 years ago
github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 338ff2c):

https://notiz-dev--pr126-feature-tailwind-2-oifas87a.web.app

(expires Thu, 14 Jan 2021 16:15:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

marcjulian commented 3 years ago

@garygrossgarten in Tailwind 2.0 new Gray colors are introduced. We should decide which we like to use, as we use gray for the background in our themes.

We should consider downloading and serving our font ourself to improve performance as cross-site caching is changing. We are currently using Muli We can still downloaded through this link, but it seems that I can not find Muli on https://fonts.google.com/specimen/Muli anymore.

marcjulian commented 3 years ago

Do we want to use tailwindcss-typography for the content and customize it to our design?

garygrossgarten commented 3 years ago

@marcjulian try it out and see what it looks like

garygrossgarten commented 3 years ago

@marcjulian what's missing? need this for my latest post

Light Theme:

Dark Theme:

General:

after: Screenshot 2020-12-15 at 13 23 21

marcjulian commented 3 years ago

@garygrossgarten a few styles such as blockquote need some more styling in prose and I am going to add the gray background color we are currently using.

marcjulian commented 3 years ago

@garygrossgarten I updated the styles please have a look. I moved most colors into tailwind.config.js, remaining color variables are necessary for dark and light mode such as --text-color and --background. I also renamed --background to --canvas to avoid names like bg-background, would be now bg-canvas. What do you think?

marcjulian commented 3 years ago

@garygrossgarten awesome! I will merge it now!